fix(android): AGP 9.0 no longer supports proguard-android.txt#1196
fix(android): AGP 9.0 no longer supports proguard-android.txt#1196jb3rndt wants to merge 1 commit intogetsentry:mainfrom
proguard-android.txt#1196Conversation
|
This PR has been automatically closed. All non-maintainer contributions must reference an existing GitHub issue. Next steps:
Please review our contributing guidelines for more details. |
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
|
This PR has been automatically closed. The referenced issue does not show a discussion between you and a maintainer. To avoid wasted effort on both sides, please discuss your proposed approach in the issue first and wait for a maintainer to respond before opening a PR. Please review our contributing guidelines for more details. |
|
Thank you for the PR! Since we really don't apply any proguard rules here, let's just remove the following snippet: buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
} and also delete the proguard-android.txt file in What do you think? |
…oguard-rules.pro`
1a298fa to
7f02db4
Compare
|
Hi Lucas, yeah sounds reasonable. I have replaced the previous commit with your suggestion :) |
Resolves #1197
📢 Type of change
📜 Description
This replaces
proguard-android.txtwithproguard-android-optimize.txtto make the package compatible with android gradle plugin v9.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps